lhotari commented on PR #22380: URL: https://github.com/apache/pulsar/pull/22380#issuecomment-2026819223
> I understand that there is a breaking change here, but I want to keep the same way with the producer rate limit, please see https://github.com/lhotari/pulsar/blob/d61f7585e8ee1d5e76ff1ff1eb0b3380bc7178c4/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java#L324, we always use the batch size. I know that it feels wrong, but changing this is a breaking change. For rate limiting purposes, limiting the entry rate instead of message rate is useful and optimally it would be configurable. Entry rate limiting is more useful from the broker load perspective. The broker doesn't really care how many messages are batched in an entry. Rate limiting by message count matters mainly for consumers since the number of messages impact the load on client side message processing. In the case of replication, that is not a concern at all. I hope this reasoning explains why I think it's not a good idea to make this change. > > Right now, when using the batch messages, the `pulsar_replication_rate_in` and `pulsar_replication_rate_out` doesn't match. > > pulsar_replication_rate_in > pulsar_replication_rate_out Isn't this a metrics issue? Can we fix this instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
