lhotari commented on code in PR #22381:
URL: https://github.com/apache/pulsar/pull/22381#discussion_r1544197678


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java:
##########
@@ -75,6 +76,10 @@ public class ReplicatedSubscriptionsController implements 
AutoCloseable, Topic.P
                     "Counter of currently pending snapshots")
             .register();
 
+    private static final Counter timedoutSnapshotsMetric = Counter
+            .build().name("pulsar_replicated_subscriptions_snapshot_timeouts")

Review Comment:
   Perhaps `pulsar_replicated_subscriptions_timedout_snapshots` would be more 
consistent with the existing 
`pulsar_replicated_subscriptions_pending_snapshots`? I don't have a strong 
opinion about this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to