lhotari commented on PR #22385: URL: https://github.com/apache/pulsar/pull/22385#issuecomment-2027227041
> > I think that AsyncTokenBucket should be used for rate limiting instead of implementing a separate solution. It was introduced in PIP-322. > > @lhotari > TimeWindow is not introduced by this PR, it exists a long time. Just reuse it here. If you think AsyncTokenBucket is better, I can fix this. Yes, I think so. It's worth checking if you could implemented the rate limiting in a similar way as it is in other Pulsar rate limiters that were refactored in PIP-322 implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
