heesung-sn commented on code in PR #22379:
URL: https://github.com/apache/pulsar/pull/22379#discussion_r1544829185
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -2244,9 +2244,18 @@ private CompletableFuture<Integer>
unloadServiceUnit(NamespaceBundle serviceUnit
closeFutures.add(topicFuture
.thenCompose(t -> t.isPresent() ? t.get().close(
disconnectClients,
closeWithoutWaitingClientDisconnect)
- : CompletableFuture.completedFuture(null)));
+ : CompletableFuture.completedFuture(null))
+ .exceptionally(e -> {
+ if (e.getCause() instanceof
BrokerServiceException.ServiceUnitNotReadyException
+ && e.getMessage().contains("Please redo
the lookup")) {
+ log.warn("[{}] Topic ownership check failed.
Skipping it", topicName);
+ return null;
Review Comment:
Identified another racing condition here.
UnloadManager should not complete the inflight jobs from the Owned event
from assignment commands. This could result in returning unload command too
fast, although the unloading is still in progress. I updated this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
