gaoran10 commented on code in PR #22393:
URL: https://github.com/apache/pulsar/pull/22393#discussion_r1548837669
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -418,16 +419,14 @@ public void sendComplete(Exception e) {
stats.incrementNumAcksReceived(latencyNanos);
}
} finally {
- interceptorMessage.getDataBuffer().release();
+ ReferenceCountUtil.safeRelease(payloadInCurrentMsg);
Review Comment:
Yes.
Just a thought: if the publish latency contains the batch delay, the metric
can't accurately reflect the latency of communication with the broker, but
maybe it's OK because it also can reflect the trend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
