sijie commented on a change in pull request #4779: Add basic authentication
capabilities to Pulsar SQL
URL: https://github.com/apache/pulsar/pull/4779#discussion_r306135654
##########
File path:
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarMetadata.java
##########
@@ -291,7 +301,12 @@ private ConnectorTableMetadata
getTableMetadata(SchemaTableName schemaTableName,
if (e.getStatusCode() == 404) {
// to indicate that we can't read from topic because there is
no schema
return null;
+ } else if (e.getStatusCode() == 401) {
+ throw new PrestoException(QUERY_REJECTED,
+ String.format("Failed to get schema information for
topic %s/%s: Unauthorized",
Review comment:
nit: schema has a different meaning in pulsar. so I would suggest being
specific here: "Failed to get pulsar schema information"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
