dao-jun commented on code in PR #22452:
URL: https://github.com/apache/pulsar/pull/22452#discussion_r1554843436
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -321,6 +323,8 @@ public void addComplete(Position position, ByteBuf
entryData, Object ctx) {
}
txnCommittedCounter.increment();
completableFuture.complete(null);
+ // need to update the last data message published
timestamp
+
topic.setLastDataMessagePublishedTimestamp(Clock.systemUTC().millis());
Review Comment:
Actually, I think update `LastDataMessagePublishedTimestamp` before or after
the txn committed doesn't matter.
Because if there is a non-txn message published to the topic before some txn
committed will also update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
