zymap commented on a change in pull request #4738: [Transaction][buffer] Add
basic operation of transaction
URL: https://github.com/apache/pulsar/pull/4738#discussion_r306206535
##########
File path:
pulsar-transaction/buffer/src/main/java/org/apache/pulsar/transaction/buffer/impl/InMemTransactionBuffer.java
##########
@@ -79,6 +81,41 @@ public int numEntries() {
}
}
+ @Override
+ public long committedAtLedgerId() {
+ return committedAtLedgerId;
+ }
+
+ @Override
+ public long committedAtEntryId() {
+ return committedAtEntryId;
+ }
+
+ @Override
+ public long lastSequenceId() {
+ return entries.lastKey();
+ }
+
+ @Override
+ public CompletableFuture<SortedMap<Long, Position>> readEntries(int
num, long startSequenceId) {
+ return FutureUtil.failedFuture(new
UnsupportedOperationException());
Review comment:
Because it related to the entry position and there is no position in memory.
So I think it is no usage in this implementation, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
