lhotari commented on PR #22461: URL: https://github.com/apache/pulsar/pull/22461#issuecomment-2042335576
> But it don't check for equality, and i don't get the explanation: > [#16618 (comment)](https://github.com/apache/pulsar/pull/16618#discussion_r980726208) I'll explain. In the current code in master branch, https://github.com/apache/pulsar/blob/a51bbdd1480b453d72891b3d68b4afd068ec374a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java#L209-L210 . The condition `topic.getLastDataMessagePublishedTimestamp() < lastCompletedSnapshotStartTime` is comparing 2 different types of timestamps: the first one is the timestamp of publishing the last message. The other one is the completion of the snapshot starting time. Checking for equality isn't necessary since those timestamps won't be the same. Does this explanation clarify that? The problem of duplicate snapshots is solved by #16651. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
