thetumbled commented on code in PR #22452:
URL: https://github.com/apache/pulsar/pull/22452#discussion_r1555575940
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -3942,9 +3942,13 @@ public void publishTxnMessage(TxnID txnID, ByteBuf
headersAndPayload, PublishCon
@Override
public CompletableFuture<Void> endTxn(TxnID txnID, int txnAction, long
lowWaterMark) {
if (TxnAction.COMMIT_VALUE == txnAction) {
- return transactionBuffer.commitTxn(txnID, lowWaterMark);
+ return transactionBuffer.commitTxn(txnID, lowWaterMark).thenRun(()
-> {
+ lastDataMessagePublishedTimestamp = Clock.systemUTC().millis();
Review Comment:
> Oh I see. So, the committed transaction messages will not be replicated to
the remote cluster without this fix?
>
> If yes,
>
> I think we should change the PR title to "[fix][broker] fix the
transaction messages cannot be replicated" And, a test for replicating
transaction messages should be added to make sure we can fix the issue end to
end
Yes, we will always skip taking snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
