mattisonchao commented on code in PR #22479:
URL: https://github.com/apache/pulsar/pull/22479#discussion_r1560432589
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -631,15 +631,20 @@ protected void startStatsUpdater(int
statsUpdateInitialDelayInSecs, int statsUpd
}
protected void startDeduplicationSnapshotMonitor() {
+ // We do not know whether users will enable deduplication on namespace
level/topic level or not, so keep this
+ // scheduled task runs.
int interval =
pulsar().getConfiguration().getBrokerDeduplicationSnapshotFrequencyInSeconds();
- if (interval > 0 &&
pulsar().getConfiguration().isBrokerDeduplicationEnabled()) {
+ if (interval > 0) {
this.deduplicationSnapshotMonitor =
OrderedScheduler.newSchedulerBuilder()
.name("deduplication-snapshot-monitor")
.numThreads(1)
.build();
deduplicationSnapshotMonitor.scheduleAtFixedRate(() ->
forEachTopic(
Topic::checkDeduplicationSnapshot)
, interval, interval, TimeUnit.SECONDS);
+ } else {
Review Comment:
Is it break the definition of configuration?
```
@FieldContext(
category = CATEGORY_POLICIES,
doc = "How often is the thread pool scheduled to check whether a
snapshot needs to be taken."
+ "(disable with value 0)"
)
private int brokerDeduplicationSnapshotFrequencyInSeconds = 120;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
