poorbarcode commented on code in PR #22479:
URL: https://github.com/apache/pulsar/pull/22479#discussion_r1560520942
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -774,7 +774,7 @@ The max allowed delay for delayed delivery (in
milliseconds). If the broker rece
@FieldContext(
category = CATEGORY_POLICIES,
doc = "How often is the thread pool scheduled to check whether a
snapshot needs to be taken."
- + "(disable with value 0)"
+ + "(must be greater than 0)"
Review Comment:
Created a separate PR https://github.com/apache/pulsar/pull/22480 to do this
change
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -631,15 +631,20 @@ protected void startStatsUpdater(int
statsUpdateInitialDelayInSecs, int statsUpd
}
protected void startDeduplicationSnapshotMonitor() {
+ // We do not know whether users will enable deduplication on namespace
level/topic level or not, so keep this
+ // scheduled task runs.
int interval =
pulsar().getConfiguration().getBrokerDeduplicationSnapshotFrequencyInSeconds();
- if (interval > 0 &&
pulsar().getConfiguration().isBrokerDeduplicationEnabled()) {
+ if (interval > 0) {
this.deduplicationSnapshotMonitor =
OrderedScheduler.newSchedulerBuilder()
.name("deduplication-snapshot-monitor")
.numThreads(1)
.build();
deduplicationSnapshotMonitor.scheduleAtFixedRate(() ->
forEachTopic(
Topic::checkDeduplicationSnapshot)
, interval, interval, TimeUnit.SECONDS);
+ } else {
+ throw new IllegalArgumentException("The config
brokerDeduplicationSnapshotFrequencyInSeconds should be"
Review Comment:
Created a separate PR https://github.com/apache/pulsar/pull/22480 to do this
change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
