lhotari commented on code in PR #22489:
URL: https://github.com/apache/pulsar/pull/22489#discussion_r1562320433
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentMessageFinderTest.java:
##########
@@ -402,11 +402,11 @@ void
testMessageExpiryWithTimestampNonRecoverableException() throws Exception {
for (int i = 0; i < totalEntries; i++) {
ledger.addEntry(createMessageWrittenToLedger("msg" + i));
}
+ retryStrategically((test) -> ledger.getState() ==
ManagedLedgerImpl.State.LedgerOpened,10, 200);
Review Comment:
`retryStrategically` should be replaced with Awaitility in most cases. I
guess `retryStrategically` was introduced to the code base before Awaitility
existed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
