poorbarcode commented on code in PR #21946:
URL: https://github.com/apache/pulsar/pull/21946#discussion_r1564805152
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java:
##########
@@ -675,30 +692,6 @@ protected void checkReplicatedSubscriptionMarker(Position
position, MessageImpl<
}
}
- @Override
- public CompletableFuture<Void> disconnect() {
- return disconnect(false);
- }
-
- @Override
- public synchronized CompletableFuture<Void> disconnect(boolean
failIfHasBacklog) {
- final CompletableFuture<Void> future = new CompletableFuture<>();
-
- super.disconnect(failIfHasBacklog).thenRun(() -> {
- dispatchRateLimiter.ifPresent(DispatchRateLimiter::close);
Review Comment:
Good catch! Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
