shibd commented on code in PR #22511:
URL: https://github.com/apache/pulsar/pull/22511#discussion_r1565864860
##########
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java:
##########
@@ -253,6 +265,12 @@ public void ack() {
completableFuture.complete(null);
}
+ @Override
+ public void fail() {
+ completableFuture.completeExceptionally(
+ new RuntimeException("Failed to process record with key: " +
getKey() + " and value: " + getValue()));
Review Comment:
Make sense to me. I used "topic:partition:offset" to replace it, so that a
unique message in Kafka can be located.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
