lhotari commented on code in PR #22515:
URL: https://github.com/apache/pulsar/pull/22515#discussion_r1566813924
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java:
##########
@@ -567,6 +602,14 @@ private static boolean isQuitCommand(String line) {
return line.equalsIgnoreCase("quit") || line.equalsIgnoreCase("exit");
}
+ private static boolean isExitModeCommand(String line) {
+ return line.equalsIgnoreCase("exitmode");
+ }
+
+ private static boolean isChangeModeCommand(String line) {
+ return line.equalsIgnoreCase("admin") ||
line.equalsIgnoreCase("client") || line.equalsIgnoreCase("config");
Review Comment:
seems like duplication. I'd assume that the ShellMode enum would have a
status lookup method instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
