shibd commented on code in PR #22552:
URL: https://github.com/apache/pulsar/pull/22552#discussion_r1574746976
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java:
##########
@@ -4695,5 +4695,58 @@ public void readEntriesFailed(ManagedLedgerException
exception, Object ctx) {
&& cursorReadPosition.getEntryId() ==
expectReadPosition.getEntryId());
}
+ @Test
+ public void testRecoverCursorWithTerminateManagedLedger() throws Exception
{
+ String mlName = "my_test_ledger";
+ String cursorName = "c1";
+
+ ManagedLedgerConfig config = new ManagedLedgerConfig();
+ ManagedLedgerImpl ledger = (ManagedLedgerImpl) factory.open(mlName,
config);
+ ManagedCursorImpl c1 = (ManagedCursorImpl)
ledger.openCursor(cursorName);
+
+ // Write some data.
+ Position p0 = ledger.addEntry("entry-0".getBytes());
+ Position p1 = ledger.addEntry("entry-1".getBytes());
+
+ // Read and ack message.
+ List<Entry> entries = c1.readEntries(2);
+ assertEquals(entries.size(), 2);
+ assertEquals(entries.get(0).getPosition(), p0);
+ assertEquals(entries.get(1).getPosition(), p1);
+ entries.forEach(Entry::release);
+
+ // Mark delete the last message.
+ c1.markDelete(p1);
+ Position markDeletedPosition = c1.getMarkDeletedPosition();
+ Assert.assertEquals(markDeletedPosition, p1);
+
+ // Terminate the managed ledger.
+ Position lastPosition = ledger.terminate();
+ assertEquals(lastPosition, p1);
+
+ // Close the ledger.
+ ledger.close();
+
+ // Reopen the ledger.
+ ledger = (ManagedLedgerImpl) factory.open(mlName, config);
+ BookKeeper mockBookKeeper = mock(BookKeeper.class);
+ final ManagedCursorImpl cursor = new ManagedCursorImpl(mockBookKeeper,
new ManagedLedgerConfig(), ledger,
+ cursorName);
+
+ // Recover the cursor.
+ cursor.recover(new VoidCallback() {
Review Comment:
Need to convert to a sync call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
