This is an automated email from the ASF dual-hosted git repository.
xyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 13ecca24 [improve] add a lint-docker command in makefile (#1207)
13ecca24 is described below
commit 13ecca24ffb6b65ac7ec36da53ecb67479518647
Author: zhou zhuohan <[email protected]>
AuthorDate: Mon Apr 22 21:23:49 2024 +0800
[improve] add a lint-docker command in makefile (#1207)
Co-authored-by: ninjazhou <[email protected]>
---
Makefile | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index df4d539d..cdae8a59 100644
--- a/Makefile
+++ b/Makefile
@@ -38,6 +38,12 @@ lint: bin/golangci-lint
bin/golangci-lint:
GOBIN=$(shell pwd)/bin go install
github.com/golangci/golangci-lint/cmd/[email protected]
+# an alternative to above `make lint` command
+# use golangCi-lint docker to avoid local golang env issues
+# https://golangci-lint.run/welcome/install/
+lint-docker:
+ docker run --rm -v $(shell pwd):/app -w /app
golangci/golangci-lint:v1.51.2 golangci-lint run -v
+
container:
docker build -t ${IMAGE_NAME} \
--build-arg GO_VERSION="${GO_VERSION}" \
