BewareMyPower commented on code in PR #1208:
URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1574823910
##########
pulsar/internal/lookup_service.go:
##########
@@ -30,8 +30,9 @@ import (
// LookupResult encapsulates a struct for lookup a request, containing two
parts: LogicalAddr, PhysicalAddr.
type LookupResult struct {
- LogicalAddr *url.URL
- PhysicalAddr *url.URL
+ IsProxyThroughServiceURL bool
Review Comment:
It seems `IsProxyThroughServiceURL` is never used?
##########
pulsar/producer_partition.go:
##########
@@ -373,10 +390,14 @@ func (p *partitionProducer) GetBuffer() internal.Buffer {
return b
}
-func (p *partitionProducer) ConnectionClosed() {
+func (p *partitionProducer) ConnectionClosed(closeProducer
*pb.CommandCloseProducer) {
Review Comment:
I see `ConnectionClosed(nil)` could be called in `connection.go`, should you
perform the null check here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
