merlimat commented on PR #22467: URL: https://github.com/apache/pulsar/pull/22467#issuecomment-2071140865
@dragosvictor I think we shouldn't worry about v1 topic names, these were deprecated long ago we should actually start to get rid of them completely. > The topic name, as is currently filled in by the [client](https://github.com/apache/pulsar/blob/c72c135541e14043370836421cfef372b1d0a0ea/pulsar-client/src/main/java/org/apache/pulsar/client/impl/metrics/MetricsUtil.java#L47) also includes the persistence part: pulsar.topic="persistent://my-property/use/my-ns/testAllCompactedOut-07b9ad7f-89cb-4800-88e8-cb3417cf0406". Yes, it's better to include, because it's part of fully-qualified name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
