BewareMyPower commented on code in PR #22562:
URL: https://github.com/apache/pulsar/pull/22562#discussion_r1575706071
##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ConsumerStats.java:
##########
@@ -25,6 +25,9 @@
* Consumer statistics.
*/
public interface ConsumerStats {
+ /** the role used for authorization. */
+ String getRole();
Review Comment:
Since this PR adds a new method to an existing public interface in the
`pulsar-xxx-api` module, it needs a PIP.
> We have a strong need to trace back the owner of a specific subscription
It's better to explain a bit more for why the role is needed here. From the
wiki of statistics
> Statistics (from German: Statistik, orig. "description of a state, a
country")[1][2] is the discipline that concerns the collection, organization,
analysis, interpretation, and presentation of data.
The role info is more like an attribute of a consumer, not a statistics.
Generally, the role info never changes unlike other fields (e.g. the in/out
rate)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
