BewareMyPower commented on PR #22567: URL: https://github.com/apache/pulsar/pull/22567#issuecomment-2072080615
> The problem with the changes in this PR is that it would make it harder to develop the workflow in a public forked repository. The main affect is the PRs that only modify the documents will still trigger the unit tests. However, as the `pulsar-site` repository was already moved out of the main repo, such PRs are becoming much less than before. So I don't think it actually makes development harder in a public forked repository. I'm also suspicious about if there is a real developer that gets benefits from such savings of GitHub actions resources. On the other hand, without this PR or another solution, the development in a private fork could be very hard. A PR needs to modify the workflow or the master branch needs to include a commit that removes these workflows to have tests executed. > We should first investigate if there's a way to add permissions to the workflow. Technically it's right. But the [`paths-filter` plugin](https://github.com/apache/pulsar-test-infra/commits/master/paths-filter) is hard to maintain for contributors not familiar with JavaScript and GitHub actions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
