heesung-sn commented on code in PR #22566:
URL: https://github.com/apache/pulsar/pull/22566#discussion_r1576674865
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java:
##########
@@ -192,7 +192,20 @@ protected void batchOperation(List<MetadataOp> ops) {
Code code = Code.get(rc);
if (code == Code.CONNECTIONLOSS) {
// There is the chance that we caused a connection
reset by sending or requesting a batch
- // that passed the max ZK limit. Retry with the
individual operations
+ // that passed the max ZK limit.
+
+ // Build the log warning message
+ // summarize the operations by type
+ String countsByType = ops.stream().collect(
+
Collectors.groupingBy(MetadataOp::getType, Collectors.summingInt(op -> 1)))
+ .entrySet().stream().map(e -> e.getValue() + "
" + e.getKey().name() + " entries")
+ .collect(Collectors.joining(", "));
+ Long totalSize =
ops.stream().collect(Collectors.summingLong(MetadataOp::size));
+ log.warn("Connection loss while executing batch
operation of {} "
Review Comment:
Also, ideally it would be great if we can emit some metics too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
