dao-jun commented on code in PR #22580:
URL: https://github.com/apache/pulsar/pull/22580#discussion_r1578943731
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1254,7 +1254,8 @@ private CompletableFuture<Optional<Topic>>
createNonPersistentTopic(String topic
nonPersistentTopic = newTopic(topic, null, this,
NonPersistentTopic.class);
} catch (Throwable e) {
log.warn("Failed to create topic {}", topic, e);
- return FutureUtil.failedFuture(e);
+ topicFuture.completeExceptionally(e);
Review Comment:
Makes sense to me, I also tried to fix the flaky test, and during the
process, I find that I didn't handle this case.
But the test keeps failing after fixed, so the issue never get fixed... I
should create another PR to fix here first...
https://github.com/apache/pulsar/pull/22256/files#diff-0210356c8a88e4efa89eb769a027fa6c166db479dbad8bbbbc704c6ed6e317f5R1254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
