mattisonchao opened a new pull request, #22582:
URL: https://github.com/apache/pulsar/pull/22582

   ### Motivation
   
   Disable deduplication on system topic to avoid recovering deduplication WAL 
(especially from offloaded topic). Because the system topic usually is a 
precondition to other topics. 
   Therefore, we should pay attention to topic loading time.
   
   Note: If the system topic loading timeout may cause dependent topics to fail 
to run.
   Dependency diagram: normal topic --rely on--> system topic --rely on--> 
deduplication recover --may rely on--> (tiered storage)
   
   ### Modifications
   
   - MessageDeduplication use `Topic#isDeduplicationEnabled` to judge if we 
should enable deduplication.
   - System topic overrides the `Topic#isDeduplicationEnabled` to return 
`false`.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to