poorbarcode commented on code in PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#discussion_r1580420056
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1595,41 +1662,50 @@ public CompletableFuture<Void> close(
}
}
- CompletableFuture<Void> clientCloseFuture =
closeWithoutWaitingClientDisconnect
- ? CompletableFuture.completedFuture(null)
- : FutureUtil.waitForAll(futures);
-
- clientCloseFuture.thenRun(() -> {
- // After having disconnected all producers/consumers, close the
managed ledger
+ CompletableFuture<Void> disconnectClientsFuture =
FutureUtil.waitForAll(futures);
Review Comment:
Since we need to initialize the variable
`closeFutures.waitDisconnectClients`, the variable `disconnectClientsFuture` is
needed 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
