poorbarcode commented on code in PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#discussion_r1582003453
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1605,40 +1691,74 @@ public CompletableFuture<Void> close(
}
}
- CompletableFuture<Void> clientCloseFuture =
closeWithoutWaitingClientDisconnect
- ? CompletableFuture.completedFuture(null)
- : FutureUtil.waitForAll(futures);
+ CompletableFuture<Void> disconnectClientsInCurrentCall = null;
+ // Note: "disconnectClientsToCache" is a non-able value, it is null
when close type is transferring.
+ MutableObject<CompletableFuture<Void>> disconnectClientsToCache = new
MutableObject<>();
Review Comment:
Done, and added another change
[here](https://github.com/apache/pulsar/pull/17524/commits/996cebaf2a156d6881c00e5fa1574c42f45a30a7#diff-5edf14cc6f25857d0cfdd26b2d3b3141230ecfb0dfa95aebf7583fd76ede4c4bR1752-R1757)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
