coderzc commented on PR #22610: URL: https://github.com/apache/pulsar/pull/22610#issuecomment-2081864440
> > It seems we don't need `maxReadPosition.compareTo((PositionImpl) getLastPosition()) != 0` judgment condition, since `maxReadPosition` also may not be a valid position for transaction topic event if `maxReadPosition < lastPosition`. > > I don't understand, why? @dao-jun `maxReadPosition` is just the position in front of the ongoing transaction. It can only ensure that this is not a pending transaction position. but it's not necessarily a normal message. See: https://github.com/apache/pulsar/blob/264722f1da9ab806c9a79196c091bfe4d03b3090/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java#L447-L459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
