lhotari opened a new pull request, #22647:
URL: https://github.com/apache/pulsar/pull/22647
WIP: This PR most likely requires a PIP and that will follow.
### Motivation
In the past brokers didn't have a stable unique identifier. In PR #21894,
the "lookupServiceAddress" was renamed to be "brokerId" so that there would be
a single unique identifier for a broker in a cluster.
This PR continues making brokerId a first class identifier for a broker. The
long term benefit is having consistency across the APIs. One reason to add this
information to the topic lookup result is to be able to use the APIs in a way
where you lookup a topic and receive that broker id. With this broker id, you
could then lookup more details about the broker in the Admin API with the
broker id.
### Modifications
- add brokerId to lookup results
- add brokerId to load manager data
- brokerId already was contained in LoadReport with the field name `name`
instead of `brokerId`. Keep the name `name` for backwards compatibility
- add client test to ensure that lookup result includes the broker id for
both binary and http lookup results
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
