dao-jun commented on PR #22610: URL: https://github.com/apache/pulsar/pull/22610#issuecomment-2094575724
> Regarding [#22572 (comment)](https://github.com/apache/pulsar/pull/22572#discussion_r1582980339), to further reduce code duplication, start `internalAsyncReverseFindPositionOneByOne` method with this part > > ``` > if (!ledger.isValidPosition(previousPosition)) { > future.complete(previousPosition); > return; > } > ``` > > and then this logic can be removed from `asyncGetLastValidPosition` and the `readEntryComplete` callback. addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
