bpereto opened a new pull request, #570: URL: https://github.com/apache/pulsar-manager/pull/570
### Motivation the current state of the master branch does not work for broker stats (they are empty) and collecting is failing with exceptions. Probably because of the implementation how the `BrokerStatsImp` finds the broker for a specified cluster. Currently, there are multiple problems: - If the Service URL differs from the broker urls, then the corresponding token for authentification is not found. ex: service url `https://brokers.pulsar.internal:8443` found brokers: `http://broker01.pulsar.internal:8080` even the brokers are configured with tls. the environment token is then not found for broker01, it matches only brokers.pulsar.internal. - enabling TLS with `tls.enabled` enables not only TLS-Transport-Encryption, it configures TLS Client Auth, which is not in all scenarios needed or wanted. I would like to have TLS Cmmunication and Token-Auth. - Broker URL Schema is not handled well - addition of `http://` or `https://` is scattered. the changes contained in this pull request should sufficiently fix broker metric collection for TLS+TokenAuth (not TLS Client Auth) environments. ### Modifications - allow specification of environment at broker stats collection to get the token - build the broker url with schema, port from specified service url. this enables the use of TLS. - specify environment and environment token when collecting stats with `collectStatsToDB` - fix axios parameter serialization which default behaviour was changed in 1.0 - updated hikari parameters for attempt to limit pool exhaustion exceptions ### Verifying this change - [x] Make sure that the change passes the `./gradlew build` checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
