dao-jun commented on PR #22564: URL: https://github.com/apache/pulsar/pull/22564#issuecomment-2097363187
> Leaving aside the issue above. > > It looks like you want to add `role` to the consumer stats, that is a good idea to track the relationship between subscriptions and users. > > There are times when the role is more sensitive information and I would recommend adding a configuration to expose the role. @nodece I don't understand why `role` name can be sensitive. It's not accessKey or username or token or something else, it is just a `role` name, users cannot accessed in by the `role` name at all. Like us, we are `Software engineer`, is `Software engineer` sensitive? The PIP is a simple change, let's keep it simple, I don't think add a `exposeRole` param is reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
