Demogorgon314 commented on code in PR #22695:
URL: https://github.com/apache/pulsar/pull/22695#discussion_r1597374418
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -582,6 +582,14 @@ The max allowed delay for delayed delivery (in
milliseconds). If the broker rece
)
private String configurationMetadataSyncEventTopic = null;
+ @FieldContext(
+ dynamic = false,
+ category = CATEGORY_SERVER,
+ doc = "If you want to enable or disable the metadata synchronizer
dynamically, this value should be true."
+ + "Enabled: Pulsar will initialize itself to update the
metadata synchronizer dynamically."
+ )
+ private boolean mayEnableMetadataSynchronizer = false;
Review Comment:
Maybe we can name the configuration as
`forceUseSeparatedConfigurationStore`? Then we can use
`isConfigurationStoreSeparated` to check the condition.
```java
public boolean isConfigurationStoreSeparated() {
return !Objects.equals(getConfigurationMetadataStoreUrl(),
getMetadataStoreUrl()) || forceUseSeparatedConfigurationStore;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
