codelipenghui commented on code in PR #22221:
URL: https://github.com/apache/pulsar/pull/22221#discussion_r1606472657
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -4155,13 +4166,14 @@ private void checkAddTimeout() {
}
OpAddEntry opAddEntry = pendingAddEntries.peek();
if (opAddEntry != null) {
- final long finalAddOpCount = opAddEntry.addOpCount;
boolean isTimedOut = opAddEntry.lastInitTime != -1
&& TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() -
opAddEntry.lastInitTime) >= timeoutSec;
if (isTimedOut) {
- log.error("Failed to add entry for ledger {} in time-out {}
sec",
- (opAddEntry.ledger != null ? opAddEntry.ledger.getId()
: -1), timeoutSec);
- opAddEntry.handleAddTimeoutFailure(opAddEntry.ledger,
finalAddOpCount);
+ log.warn("[{}] Failed to add entry {}:{} in time-out {} sec",
this.name,
+ opAddEntry.ledger != null ? opAddEntry.ledger.getId()
: -1,
+ opAddEntry.entryId, timeoutSec);
+ currentLedgerTimeoutTriggered.set(true);
Review Comment:
Do we need to set it back to false finally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
