thetumbled commented on code in PR #22753:
URL: https://github.com/apache/pulsar/pull/22753#discussion_r1610892192
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -1122,6 +1126,32 @@ public void writeBrokerDataOnZooKeeper(boolean force) {
}
}
+ /**
+ * sort bundles by load and select topK bundles for each broker.
+ * @return the number of bundles selected
+ */
+ private int selectTopKBundle() {
+ bundleArr.clear();
+ bundleArr.addAll(loadData.getBundleData().entrySet());
+
+ int maxNumberOfBundlesInBundleLoadReport = pulsar.getConfiguration()
Review Comment:
It does, filtering too many bundles will degrade the performance of load
balance.
But i have a question, why do we set the default value of
`loadBalancerMaxNumberOfBundlesInBundleLoadReport` to be 10? shouldn't we
disable the topK filtering logic for `ExtensibleLoadManagerImpl` too? don't
`ExtensibleLoadManagerImpl` have the simillar degradation problem of
loadbalance when we filter most of the bundles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
