Demogorgon314 commented on code in PR #22769:
URL: https://github.com/apache/pulsar/pull/22769#discussion_r1612624344
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java:
##########
@@ -748,4 +767,55 @@ public void testDeletePartitionedTopic() throws Exception {
.persistentTopicExists(TopicName.get(topicName).getPartition(1)).join());
}
}
+
+ @Test
+ public void testNoExpandTopicPartitionsWhenDisableTopicLevelReplication()
throws Exception {
+ final String topicName = BrokerTestUtil.newUniqueName("persistent://"
+ replicatedNamespace + "/tp_");
+ admin1.topics().createPartitionedTopic(topicName, 2);
+
+ // Verify replicator works.
+ verifyReplicationWorks(topicName);
+
+ // Disable topic level replication.
+ setTopicLevelClusters(topicName, Arrays.asList(cluster1), admin1,
pulsar1);
+ setTopicLevelClusters(topicName, Arrays.asList(cluster2), admin2,
pulsar2);
+
+ // Expand topic.
+ admin1.topics().updatePartitionedTopic(topicName, 3);
+
assertEquals(admin1.topics().getPartitionedTopicMetadata(topicName).partitions,
3);
+
+ // Wait for async tasks that were triggered by expanding topic
partitions.
+ Thread.sleep(3 * 1000);
+
+ // Verify: the topics on the remote cluster did not been expanded.
+
assertEquals(admin2.topics().getPartitionedTopicMetadata(topicName).partitions,
2);
+
+ cleanupTopics(() -> {
+ admin1.topics().deletePartitionedTopic(topicName, false);
+ admin2.topics().deletePartitionedTopic(topicName, false);
+ });
+ }
+
+ @Test
+ public void testExpandTopicPartitionsOnNamespaceLevelReplication() throws
Exception {
+ final String topicName = BrokerTestUtil.newUniqueName("persistent://"
+ replicatedNamespace + "/tp_");
+ admin1.topics().createPartitionedTopic(topicName, 2);
+
+ // Verify replicator works.
+ verifyReplicationWorks(topicName);
+
+ // Expand topic.
+ admin1.topics().updatePartitionedTopic(topicName, 3);
+
assertEquals(admin1.topics().getPartitionedTopicMetadata(topicName).partitions,
3);
+
+ // Verify: the topics on the remote cluster did not been expanded.
Review Comment:
The code comment is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
