RobertIndie commented on code in PR #22762:
URL: https://github.com/apache/pulsar/pull/22762#discussion_r1615386904


##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java:
##########
@@ -1638,6 +1638,7 @@ void expireMessagesForAllSubscriptions(String topic, long 
expireTimeInSeconds)
 
     /**
      * Peek messages from a topic subscription.
+     * This method will show server marker, uncommitted and aborted messages 
for transaction by default.

Review Comment:
   This seems inconsistent with the pulsar-client-tool. [The 
proposal](https://github.com/apache/pulsar/pull/22746/files?short_path=936b339#diff-936b3395e5efb7b110af6294ba1a0a6a597ca6ce612b57542a37ba3956b3d020)
  says that we shouldn't show these marker messages by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to