dao-jun commented on code in PR #22779:
URL: https://github.com/apache/pulsar/pull/22779#discussion_r1617803645
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -81,6 +84,7 @@
import org.apache.pulsar.common.protocol.schema.SchemaData;
import org.apache.pulsar.common.protocol.schema.SchemaVersion;
import org.apache.pulsar.common.util.FutureUtil;
+import org.checkerframework.checker.units.qual.C;
Review Comment:
seems unused
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -2559,6 +2562,8 @@ public CompletableFuture<? extends TopicStatsImpl>
asyncGetStats(GetStatsOptions
stats.waitingPublishers = getWaitingProducersCount();
stats.bytesOutCounter = bytesOutFromRemovedSubscriptions.longValue();
stats.msgOutCounter = msgOutFromRemovedSubscriptions.longValue();
+ stats.bytesOutInternalCounter =
bytesOutFromRemovedSystemSubscriptions.longValue();
Review Comment:
No, seems not missed.
This line just add removed subscriptions stats, active system subscriptions'
stats added:
https://github.com/apache/pulsar/blob/352c316bd4c1f85b546ad70271feff78eae8f78a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2595-L2596
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -157,10 +161,14 @@ public abstract class AbstractTopic implements Topic,
TopicPolicyListener<TopicP
protected final LongAdder msgOutFromRemovedSubscriptions = new LongAdder();
protected final LongAdder bytesOutFromRemovedSubscriptions = new
LongAdder();
+ protected final LongAdder bytesOutFromRemovedSystemSubscriptions = new
LongAdder();
+ protected final LongAdder msgOutFromRemovedSystemSubscriptions = new
LongAdder();
Review Comment:
The PIP not contains any metric like
`pulsar_broker_out_msgs_total_internal`, please avoid this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
