thetumbled opened a new pull request, #22794:
URL: https://github.com/apache/pulsar/pull/22794
### Motivation
PR https://github.com/apache/pulsar/pull/17573 has fixed cases that
consumer commit offset periodically. It update `lastActive` field of cursor
when consumer commit the offset.
But there is still corner case that the consumer do not commit the offset
for any reason. For example, there is no content in the topic could be read,
so the consumer do not commit the offset reasonably. In such case we has no
reason delete the subscription.
Anyway, **we should be cautious with the delete operation, which could
result into data duplication or loss.**
This is the second solution trying to solve problem described in
https://github.com/apache/pulsar/pull/21692.
PR https://github.com/apache/pulsar/pull/21692 try to update the last active
info every time broker do expiration check.
But strictly speaking, we can't fix all the cases. If we fail to persist the
cursor info, the incorrect sub deletion occurs too.
Incorrect deletion of subscription causes serious consequence, such as
duplication or data lost.
In my opinion, missing deletion are better than incorrect deletion, so this
pr try to avoid all the incorrect deletion even there is posibility of missing
deletion.
### Modifications
Do not recover last active info from cursor info in zookeeper.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
