RobertIndie opened a new pull request, #22797:
URL: https://github.com/apache/pulsar/pull/22797
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
### Motivation
Currently, when we create a shadow topic for a partitioned topic, the shadow
topic won't get any messages from the source topic.
### Root cause
Suppose we have a shadow topic `test-shadow` which shadows messages from the
source topic `test`. And they should all be the partitioned topic. When
initializing the ShadowManagedLedger for the `test-shadow-partition-0`, it will
create a ShadowReplicator that gets messages from `test-partition-0` but
replicates messages to the wrong topic `test-shadow`. Therefore the shadow
topic won't get any messages.
### Solution
The solution is to create each ShadowReplicator replicate message from
`test-partition-X` to `test-shadow-partition-X`. I this way, we could also
ensure the message ording.
However, the shadow topic must have more partitions than the source topic.
When the source topic expands its number of partitions, we cannot automatically
increase the partitions of the shadow topic because it may be in a different
namespace with distinct permissions and configurations.
Therefore, I suggest that before expanding the source topic, we should first
check if all associated shadow topics have been expanded. If not, we should
throw an error to inform the user to expand all shadow topics first. Also, when
setting up the shadow topic for the source topic, avoid adding "-partition-N"
at the end. Otherwise, the ShadowReplicator will not function properly. And in
that case, we should also throw the exception to inform the user.
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
