dao-jun opened a new pull request, #22802:
URL: https://github.com/apache/pulsar/pull/22802
### Motivation
For BucketDelayedDeliveryTracker, we store the Bucket metadata(position) in
Cursor#properties, and remove the property *before* delete `ImmutableBucket`.
There is a corner case that it could be remove Cursor#properties succeed but
delete `ImmutableBucket` failed.
Since we store the Bucket in Ledgers, if remove Cursor#properties succeed
but delete `ImmutableBucket` failed, the ledger may have a change to be an
*orphan* ledger, not reachable and not usable.
The PR is for the purpose of handle the case, remove Cursor#properties
*after* delete `ImmutableBucket`, if the `Bucket` delete succeed but remove
Cursor#properties failed we can detect it in the `recover` phase and remove the
properties, to keep the data consistent and avoid orphan ledgers.
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
