dao-jun commented on code in PR #22794:
URL: https://github.com/apache/pulsar/pull/22794#discussion_r1622379651
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -3227,26 +3227,30 @@ public void checkInactiveSubscriptions() {
final Integer nsExpirationTime =
policies.subscription_expiration_time_minutes;
final long expirationTimeMillis = TimeUnit.MINUTES
.toMillis(nsExpirationTime == null ? defaultExpirationTime
: nsExpirationTime);
- if (expirationTimeMillis > 0) {
- subscriptions.forEach((subName, sub) -> {
- if (sub.dispatcher != null &&
sub.dispatcher.isConsumerConnected()
- || sub.isReplicated()
- || isCompactionSubscription(subName)) {
- return;
- }
- if (System.currentTimeMillis() -
sub.cursor.getLastActive() > expirationTimeMillis) {
- sub.delete().thenAccept(v -> log.info("[{}][{}] The
subscription was deleted due to expiration "
- + "with last active [{}]", topic, subName,
sub.cursor.getLastActive()));
- }
- });
- }
+ checkInactiveSubscriptions(expirationTimeMillis);
} catch (Exception e) {
if (log.isDebugEnabled()) {
log.debug("[{}] Error getting policies", topic);
}
}
}
+ public void checkInactiveSubscriptions(long expirationTimeMillis) {
Review Comment:
Make the method private or `VisableTesting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
