rdhabalia commented on code in PR #22843:
URL: https://github.com/apache/pulsar/pull/22843#discussion_r1626675221
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataStoreException.java:
##########
@@ -156,6 +156,23 @@ public InvalidPathException(String path) {
}
}
+ /**
+ * Metadata operation timed out.
+ */
+ public static class TimeoutException extends RuntimeException {
Review Comment:
>If not, why not use the ordinary TimeoutException?
` java.util.concurrent.TimeoutException` is a checked exception.
`BookieRackAffinityMapping::setConf` API belongs to different project
(`BookKeeper`) and we can not throw any new random checked exception.
Therefore, we need meaningful RuntimeException for metadata-Timeout. Therefore
we added this TimeoutException into `MetadataStoreException` but
`MetadataStoreException` is not a RuntimeException so, this new exception
doesn't extend `MetadataStoreException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
