thetumbled opened a new issue, #22847:
URL: https://github.com/apache/pulsar/issues/22847

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) 
and found nothing similar.
   
   
   ### What issue do you find in Pulsar docs?
   
   There are some errors in the description of the UniformLoadShedder.
   
https://pulsar.apache.org/docs/next/administration-load-balance/#uniformloadshedder
   
   
![image](https://github.com/apache/pulsar/assets/52550727/34710a37-3cd8-4be6-9807-90a59bf979a1)
   
   We judge whether MsgRateThresholdExceeded by `(Max-Min)/Min > Threshold` as 
the graph show. But judge whether MsgThroughputThresholdExceeded by `Max/Min > 
Threshold`.
   ```
           double msgRateDifferencePercentage = ((maxMsgRate.getValue() - 
minMsgRate.getValue()) * 100)
                   / (minMsgRate.getValue());
           double msgThroughputDifferenceRate = maxThroughput.getValue() / 
minThroughput.getValue();
   
           // if the threshold matches then find out how much load needs to be 
unloaded by considering number of msgRate
           // and throughput.
           boolean isMsgRateThresholdExceeded = 
conf.getLoadBalancerMsgRateDifferenceShedderThreshold() > 0
                   && msgRateDifferencePercentage > 
conf.getLoadBalancerMsgRateDifferenceShedderThreshold();
           boolean isMsgThroughputThresholdExceeded = conf
                   
.getLoadBalancerMsgThroughputMultiplierDifferenceShedderThreshold() > 0
                   && msgThroughputDifferenceRate > conf
                   
.getLoadBalancerMsgThroughputMultiplierDifferenceShedderThreshold();
   ```
   
   ### What is your suggestion?
   
   Correct the description of UniformLoadShedder.
   
   ### Any reference?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to