merlimat commented on PR #22853:
URL: https://github.com/apache/pulsar/pull/22853#issuecomment-2151004493
@rdhabalia
> if there is no issue with https://github.com/apache/pulsar/pull/22842 then
can we merge it?
There are still issues wiht #22842:
1. It's only address 1 usage of a blocking API that is used in multiple
places as if it were non-blocking
2. Does not solve the problem that if there's a timeout, it falls back to
use default BK client, which might break the assumptions
PTAL at this PR, it's a similar change, though it brings it closer to the BK
client creation, so that all the factories expose non-blocking API. I believe
it's a more general solution than #22842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
