shibd commented on code in PR #22860:
URL: https://github.com/apache/pulsar/pull/22860#discussion_r1629697516
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java:
##########
@@ -1434,13 +1432,6 @@ public void testCleanupTopic() throws Exception {
// Ok
}
- final CompletableFuture<Optional<Topic>> timedOutTopicFuture =
topicFuture;
- // timeout topic future should be removed from cache
Review Comment:
This unit test assumes a manager ledger that can never be completed to mock
topic create timeout, which does not make sense in a production scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
