(pulsar) branch master updated: [improve] [broker] Fail fast when it failed to create LoadSheddingStrategy instance (#22827)

[xyz]

This is an automated email from the ASF dual-hosted git repository.

xyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 1770cbc20c1 [improve] [broker] Fail fast when it failed to create 
LoadSheddingStrategy instance (#22827)
1770cbc20c1 is described below

commit 1770cbc20c12da596fc7cf436ff23271b7771682
Author: Wenzhi Feng <52550727+thetumb...@users.noreply.github.com>
AuthorDate: Wed Jun 12 10:47:28 2024 +0800

    [improve] [broker] Fail fast when it failed to create LoadSheddingStrategy 
instance (#22827)
---
 .../broker/loadbalance/impl/ModularLoadManagerImpl.java       | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
index 5d08ea9c3c3..764580e9b6d 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
@@ -292,15 +292,8 @@ public class ModularLoadManagerImpl implements 
ModularLoadManager {
     }
 
     private LoadSheddingStrategy createLoadSheddingStrategy() {
-        try {
-            return 
Reflections.createInstance(conf.getLoadBalancerLoadSheddingStrategy(), 
LoadSheddingStrategy.class,
-                    Thread.currentThread().getContextClassLoader());
-        } catch (Exception e) {
-            log.error("Error when trying to create load shedding strategy: {}",
-                    conf.getLoadBalancerLoadPlacementStrategy(), e);
-        }
-        log.error("create load shedding strategy failed. using OverloadShedder 
instead.");
-        return new OverloadShedder();
+        return 
Reflections.createInstance(conf.getLoadBalancerLoadSheddingStrategy(), 
LoadSheddingStrategy.class,
+                Thread.currentThread().getContextClassLoader());
     }
 
     /**