lhotari opened a new pull request, #22923:
URL: https://github.com/apache/pulsar/pull/22923
This reverts commit fa745384c2c3ea8c16e6c0cd078328a653fa3073.
### Motivation
#22921 reverted the change in #22867 to use correct way of passing
parameters in shell scripts.
The correct syntax is `"$@"`.
In #22921, the argumentation was that a command `bin/pulsar zookeeper-shell
--run-once "ls /ledgers"` no longer works.
This type of command has always been invalid for 2 reasons:
- `bin/pulsar zookeeper-shell` has never supported `--run-once` parameter.
- there's a Python based `zk-shell` which supports this syntax.
`bin/pulsar zookeeper-shell` doesn't use `zk-shell` under the covers.
- `bin/pulsar zookeeper-shell` has never supported quoting the arguments to
the command. This happened to work because of invalid parameter passing which
is fixed by #22867
- The Python based `zk-shell` requires the `--run-once "ls /path"` syntax.
`bin/pulsar zookeeper-shell` doesn't use `zk-shell` under the covers.
### Modifications
- revert commit fa745384c2c3ea8c16e6c0cd078328a653fa3073 / PR #22921
<!-- Describe the modifications you've done. -->
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
