This is an automated email from the ASF dual-hosted git repository.
zike pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 827d6827 [improve] Reuse function checkMsgIDPartition (#1232)
827d6827 is described below
commit 827d68273830d1038983aeb2750189a408d49cd5
Author: crossoverJie <[email protected]>
AuthorDate: Mon Jul 1 18:31:46 2024 +0800
[improve] Reuse function checkMsgIDPartition (#1232)
### Modifications
Reuse function checkMsgIDPartition.
---
pulsar/consumer_impl.go | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/pulsar/consumer_impl.go b/pulsar/consumer_impl.go
index 291471cd..679054a0 100644
--- a/pulsar/consumer_impl.go
+++ b/pulsar/consumer_impl.go
@@ -856,17 +856,10 @@ func toProtoInitialPosition(p
SubscriptionInitialPosition) pb.CommandSubscribe_I
}
func (c *consumer) messageID(msgID MessageID) *trackingMessageID {
- mid := toTrackingMessageID(msgID)
-
- partition := int(mid.partitionIdx)
- // did we receive a valid partition index?
- if partition < 0 || partition >= len(c.consumers) {
- c.log.Warnf("invalid partition index %d expected a partition
between [0-%d]",
- partition, len(c.consumers))
+ if err := c.checkMsgIDPartition(msgID); err != nil {
return nil
}
-
- return mid
+ return toTrackingMessageID(msgID)
}
func addMessageCryptoIfMissing(client *client, options *ConsumerOptions,
topics interface{}) error {
