ivan-penchev commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208768095
> @ivan-penchev I noticed this PR doesn't add a test, could you add a test for the producer and consumer with this logger? @nodece I appreciate the need for a test to accompany this update. I'm willing to write one, but I could use some assistance, given that the current test suite doesn't cover the logger. 1. Where should I place the test? 2. What should I be testing? For 2 you could see - in my PR description, I did an integration test where I started a producer with logrus, and producer with slog - and then I compared the output of both loggers, in terms of length and keys (since I was doing json). But this seems too complicated and not needed for what I was trying to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
